🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: gnu.utils.bug
Article #491

GNU Make 3.56: Core dump fix for opts with args

#491
From: Chip Salzenberg
Date: Wed, 11 Oct 1989 15:56
45 lines
1371 bytes
[BUG FIX]

Fix core dump bug when a command line option that is _supposed_ to be
    followed by an argument, isn't.

Index: main.c
***************
*** 909,913 ****
  		      break;
  		    case string:
! 		      if (*sw == '\0')
  			arg = argv[++i];
  		      else
--- 930,934 ----
  		      break;
  		    case string:
! 		      if ((*sw == '\0') && (i + 1) < argc)
  			arg = argv[++i];
  		      else
***************
*** 943,947 ****
  
  		    case positive_int:
! 		      if (*sw == '\0')
  			arg = argv[++i];
  		      else
--- 964,968 ----
  
  		    case positive_int:
! 		      if ((*sw == '\0') && (i + 1) < argc)
  			arg = argv[++i];
  		      else
***************
*** 979,983 ****
  
  		    case floating:
! 		      if (*sw == '\0')
  			arg = argv[++i];
  		      else
--- 1000,1004 ----
  
  		    case floating:
! 		      if ((*sw == '\0') && (i + 1) < argc)
  			arg = argv[++i];
  		      else
Technical Details
Message-ID: <m0gElJJ-0007JGC@ateng.ateng.com>
Path: arc1-ca.pugleaf.net!utzoo!utgpu!jarvis.csri.toronto.edu!rutgers!ucsd!tut.cis.ohio-state.edu!ateng.ateng.com!chip

Show Full Headers
Complete Article Headers
Path: arc1-ca.pugleaf.net!utzoo!utgpu!jarvis.csri.toronto.edu!rutgers!ucsd!tut.cis.ohio-state.edu!ateng.ateng.com!chip
From: chip@ateng.ateng.com (Chip Salzenberg)
Newsgroups: gnu.utils.bug
Subject: GNU Make 3.56: Core dump fix for opts with args
Message-ID: <m0gElJJ-0007JGC@ateng.ateng.com>
Date: 11 Oct 89 15:56:08 GMT
Sender: daemon@tut.cis.ohio-state.edu
Distribution: gnu
Organization: GNUs Not Usenet
Lines: 45