GNU finger 1.35 bug in lookup_tty in lib/tty.c

Article View: gnu.utils.bug

Article #756

#756

From: Minh Tran-Le
Date: Mon, 07 Sep 1992 21:17

28 lines
1215 bytes

The code for the function lookup_tty.c in lib/tty.c return a pointer
to stack allocated buffer.  That buffer should declared static.

Here is the change need to the file lib/tty.c.

Minh Tran-Le.
---------------------------------------------------------------------------
*** tty.c-	Thu Aug 20 09:55:04 1992
--- tty.c	Mon Sep  7 14:09:36 1992
***************
*** 86,90 ****
    char *fingerdir, *ttylocfile, *path_concat ();
    FILE *stream;
!   char buffer[256];
  
    stream = fopen (TTYLOCFILE, "r");
--- 91,95 ----
    char *fingerdir, *ttylocfile, *path_concat ();
    FILE *stream;
!   static char buffer[256];
  
    stream = fopen (TTYLOCFILE, "r");

-- 
Minh Tran Le.

ARPANET: tranle@intellicorp.arpa
UUCP:    ...sun!icmv!mtranle

Technical Details

Message-ID: <mtranle.715900633@rigel>

Path: arc1-ca.pugleaf.net!sparky!uunet!cis.ohio-state.edu!icmv.UUCP!mtranle%rigel

Show Full Headers

Complete Article Headers

Newsgroups: gnu.utils.bug
Path: arc1-ca.pugleaf.net!sparky!uunet!cis.ohio-state.edu!icmv.UUCP!mtranle%rigel
From: mtranle%rigel@icmv.UUCP (Minh Tran-Le)
Subject: GNU finger 1.35 bug in lookup_tty in lib/tty.c
Message-ID: <mtranle.715900633@rigel>
Sender: gnulists@ai.mit.edu
Reply-To: icmv!tranle%caliph@uunet.uu.net
Organization: IntelliCorp Inc.
Distribution: gnu
Date: Mon, 7 Sep 1992 21:17:13 GMT
Approved: bug-gnu-utils@prep.ai.mit.edu
Lines: 29