Article View: gnu.utils.bug
Article #774shellutils 1.7: getugroups, su
From: Karl Berry
Date: Wed, 09 Sep 1992 12:55
Date: Wed, 09 Sep 1992 12:55
74 lines
2759 bytes
2759 bytes
Compiling the shell utilities 1.7 on a 486 running Interactive Unix 2.2.1.
I get a warning compiling lib/getugroups.c, since getgrent is
undeclared. Since this is not a POSIX function, I don't understand why
it is declare in the !_POSIX_VERSION part of the conditional. Perhaps
it should just be declared unconditionally.
(As an aside, it also seems bizarre to me that there are #ifdef's for
`sun' and `ultrix' in the course of defining GETGROUPS_T. Seems like
the hardware has absolutely nothing to do with whether gid_t is present.)
Also, in src/Makefile.in, I don't understand why `su' is not simply
included as part of `PROGS', rather than as a separate target that
always gets made.
I also had one serious problem, date always dumping core, but as that
turned out to be a problem in Autoconf, I'm reporting it separately.
Here are diffs.
Sun Sep 6 10:19:52 1992 Karl Berry (karl@hayley)
* src/Makefile.in (PROGS): include `su' here.
(all): instead of separately here.
* getugroups.c (getgrent) [_POSIX_VERSION]: declare this.
(getgrent) [!_POSIX_VERSION]: don't declare it.
*** lib/ORIG/getugroups.c Fri Jul 24 17:10:38 1992
--- lib/getugroups.c Sun Sep 6 09:45:47 1992
***************
*** 30,37 ****
#else /* sun or ultrix */
#define GETGROUPS_T int
#endif /* not sun and not ultrix */
- #else /* not _POSIX_VERSION */
struct group *getgrent ();
#define GETGROUPS_T int
#endif /* _POSIX_VERSION */
--- 30,37 ----
#else /* sun or ultrix */
#define GETGROUPS_T int
#endif /* not sun and not ultrix */
struct group *getgrent ();
+ #else /* not _POSIX_VERSION */
#define GETGROUPS_T int
#endif /* _POSIX_VERSION */
*** src/ORIG/Makefile.in Tue Aug 25 19:30:11 1992
--- src/Makefile.in Sun Sep 6 09:59:34 1992
***************
*** 28,37 ****
false.sh true.sh
PROGS = basename date dirname env expr false groups id logname \
! pathchk printenv printf sleep tee test true tty who whoami yes \
@PROGS@
! all: $(PROGS) su
.PHONY: all
.c.o:
--- 28,37 ----
false.sh true.sh
PROGS = basename date dirname env expr false groups id logname \
! pathchk printenv printf sleep su tee test true tty who whoami yes \
@PROGS@
! all: $(PROGS)
.PHONY: all
.c.o:
Technical Details
Message-ID:
<199209092055.AA09085@claude.cs.umb.edu>Path:
arc1-ca.pugleaf.net!sparky!uunet!cis.ohio-state.edu!claude.cs.umb.edu!karlShow Full Headers
Complete Article Headers
Newsgroups: gnu.utils.bug Path: arc1-ca.pugleaf.net!sparky!uunet!cis.ohio-state.edu!claude.cs.umb.edu!karl From: karl@claude.cs.umb.edu (Karl Berry) Subject: shellutils 1.7: getugroups, su Message-ID: <199209092055.AA09085@claude.cs.umb.edu> Sender: gnulists@ai.mit.edu Reply-To: karl@cs.umb.edu Organization: GNUs Not Usenet Distribution: gnu Date: Wed, 9 Sep 1992 12:55:29 GMT Approved: bug-gnu-utils@prep.ai.mit.edu Lines: 75