File stream leak in make 3.62

Thread View: gnu.utils.bug

1 messages

[T] Back to Threads [V] Tree View [G] Group Articles

1 total messages Started by Hod Greeley Wed, 04 Nov 1992 18:12

#1020

Author: Hod Greeley
Date: Wed, 04 Nov 1992 18:12

25 lines
1338 bytes

Hi,
I came across a small problem using make 3.62 on a sun sparc II under
SunOS 4.1.1.  It's in glob_in_dir in glob.c.  When globbing files, the
directory streams aren't closed, and eventually opendir fails with an
errno indicating too many descriptors open for the process.  I can
send a short makefile that shows how the problem arose for me if you
want, but I think it's pretty straightforward.  Here's the patch I
made.  Hope this helps.

*** /reef/hod/src/make-3.62/glob/glob.c Sat Oct 19 16:39:23 1991
--- glob.c      Wed Nov  4 23:10:31 1992
***************
*** 477,482 ****
--- 477,483 ----
              names = new;
              ++nfound;
            }
+       closedir(stream);
      }

    if (nfound == 0 && (flags & GLOB_NOCHECK))


Hod Greeley
hod@cucbs.chem.columbia.edu

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads