Bug in make-3.62 in file glob/glob.c

Thread View: gnu.utils.bug

1 messages

[T] Back to Threads [V] Tree View [G] Group Articles

1 total messages Started by Derek Ney Tue, 21 Jul 1992 14:56

#169

Author: Derek Ney
Date: Tue, 21 Jul 1992 14:56

25 lines
1271 bytes

I have discovered a bug in GNU make version 3.62 in
the filename globbing routine glob_in_dir(). On line
451 of file glob/glob.c, a directory is opened with
opendir(), but it is never closed. This causes make
to eat up one file descriptor each time this routine
is called. One of the most common things that calls this
is the wildcard function. Make eventually runs out of 
file descriptors if the wildcard function is called too
many times. If fixed the bug by initializing the variable
stream to NULL and then closing the stream before the
return with closedir() if stream was non-null. Following
are diffs for my fixes
diff glob.c.orig glob.c
446a447,448
>       stream = NULL;
> 
511a514,516
>       if (stream != NULL)
>               closedir(stream);
> 
519a525,528
> 
>       if (stream != NULL)
>               closedir(stream);
>

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads