screen3.2 bug & tiny patch

Thread View: gnu.utils.bug

1 messages

[T] Back to Threads [V] Tree View [G] Group Articles

1 total messages Started by Geoff Wing Sat, 31 Oct 1992 12:29

#30

Author: Geoff Wing
Date: Sat, 31 Oct 1992 12:29

34 lines
1664 bytes

Screen3.2 has a small bug seen if one has the "shell" keyword in one's
.screenrc file. Screen tries to free memory it obtained through a getenv()
and sgi/sysv machines (and probably some others) don't like this.
Here's a tiny patch for it:

*** screen.c	Sat Oct 31 01:13:38 1992
--- screen.c.orig	Fri Oct 23 12:24:48 1992
***************
*** 766,774 ****
        signal(SIGBUS, CoreDump);
        signal(SIGSEGV, CoreDump);
      }
!   if (!ShellProg && (ShellProg = getenv("SHELL")) == 0)
!     if ((ShellProg = strdup(DefaultShell)) == NULL)
!       abort(); /* ParseSaveStr may try to free ShellProg */
    ShellArgs[0] = ShellProg;
  #ifdef NETHACK
    nethackflag = (getenv("NETHACKOPTIONS") != NULL);
--- 766,773 ----
        signal(SIGBUS, CoreDump);
        signal(SIGSEGV, CoreDump);
      }
!   if (!ShellProg && (ShellProg = getenv("SHELL")) == 0)
!     ShellProg = DefaultShell;
    ShellArgs[0] = ShellProg;
  #ifdef NETHACK
    nethackflag = (getenv("NETHACKOPTIONS") != NULL);


-- 
        Geoff C. Wing         | P.O. Box 4422
  mason@phoenix.apana.org.au  | Uni. of Melbourne
                              | Victoria 3052
Hurt...Agony...Pain...LOVE-IT | Australia

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads