bug in make-3.56/commands.c?

Thread View: gnu.utils.bug

1 messages

[T] Back to Threads [V] Tree View [G] Group Articles

1 total messages Started by Marty Sat, 07 Oct 1989 16:50

#476

Author: Marty
Date: Sat, 07 Oct 1989 16:50

43 lines
1456 bytes

While reporting gnumake-3.56 to ms/dos (the dreaded system), I stumbled
across what seems to be wrong code -- I don't know if anyone else picked up
on it.

*** ../make-3.56/commands.c	Sun Sep 17 19:36:04 1989
--- commands.c	Sat Oct  7 12:40:59 1989
***************
*** 128,138 ****
        percent = savestring (p, strlen (p) - 1);
      }
    else
      {
        at = savestring (file->name, strlen (file->name));
        percent = "";
      }
- #endif
  
    DEFINE_VARIABLE ("@", 1, at);
    DEFINE_VARIABLE ("%", 1, percent);
--- 128,138 ----
        percent = savestring (p, strlen (p) - 1);
      }
    else	
+ #endif
      {
        at = savestring (file->name, strlen (file->name));
        percent = "";
      }
  
    DEFINE_VARIABLE ("@", 1, at);
    DEFINE_VARIABLE ("%", 1, percent);


at and percent are unitialized autos at DEFINE_VARIABLE without the change.

I haven't seen any bad behavior, but this looked wrong.

marty
ARPA:	leisner.henr@xerox.com
GV:  leisner.henr
NS:  leisner:wbst139:xerox
UUCP:	hplabs!arisia!leisner

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads