🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

1 total messages Started by Robert Crowe Thu, 10 Sep 1992 00:42
problem with tar-1.11 and -v option.
#778
Author: Robert Crowe
Date: Thu, 10 Sep 1992 00:42
61 lines
2441 bytes
I just finished installing tar-1.11 on our SGI's (4D/25,Indigos;
IRIX-4.01), and I ran into a problem.  When specifying the -v option
with the -c option, the program core dumps. I traced the problem to
the fact that current_file_name never gets set when going through the 
create code.  My fix was ass follows:

======= Diff Starts here ===========
*** create.c	Wed Sep  9 17:21:37 1992
--- create.c.~2~	Wed Sep  9 17:13:31 1992
***************
*** 1273,1279 ****
  		head = header;
  		/* hstat is already set up */
  		head_standard = f_standard;
! 		current_file_name = header->header.arch_name; /* Added by bob. */
  		print_header();
  	}
  
--- 1273,1279 ----
  		head = header;
  		/* hstat is already set up */
  		head_standard = f_standard;
! 		current_file_name = name; /* Added by bob. */
  		print_header();
  	}
  
============ Diff ends here =============

There may be a better place to set current_file_name; If so please
post it and I will gladly apply that instead.

The actual place where it was dumping core was in quote_copy_string,
called from ~ line 536 in list.c:

        if (f_verbose <= 1) {
                /* Just the fax, mam. */
                char *name;

                name=quote_copy_string(current_file_name);  <This is the Call>
                if(name==0)
                        name=current_file_name;
 

Other than that, everything seems to work fine. Granted I have not
tested extensively yet. 

Thanks, the new features seem like they will come in real handy.

Bob.


P.S.  The makefile wants to build an info file ( which I love to have... ),
      But the .texi file seems to be missing in the distribution I
      grabbed (tar-1.11.tar.Z). Is it available elsewhere?


============================================================
Bob Crowe                      Voice:   (619) 931-2695
Pre-Press Technologies.        Email:    bob@prepress.com
2443 Impala dr.		       FAX:     (619) 931-2698
Carlsbad, Ca 92008.
Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads