imageto dumps core with untyped input filename

Thread View: gnu.utils.bug

1 messages

[T] Back to Threads [V] Tree View [G] Group Articles

1 total messages Started by peter c halverson Thu, 10 Sep 1992 21:49

#789

Author: peter c halverson
Date: Thu, 10 Sep 1992 21:49

24 lines
1190 bytes

Problem Description:

Assuming an IMG input file with the name "gbbb.img", imageto dumps core
with a segmentation fault given the arguments:

    % imageto gbbb

(e.g. accidently omitting the ".img" extension).

Cursory investigation reveals that in the routine "set_input_format" in
"imageto/main.c" is not checking for a NULL return value from "find_suffix"
before doing STREQ comparisons on the result.  

Suggested fix:

   imageto/main.c:
   998c998
   <   if (STREQ (input_extension, "img"))
   ---
   >   if (input_extension && STREQ (input_extension, "img"))
   1001c1001
   <   else if (STREQ (input_extension, "pbm"))
   ---
   >   else if (input_extension && STREQ (input_extension, "pbm"))

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads