Thread View: gnu.utils.bug
1 messages
1 total messages
Started by Goeran Uddeborg
Wed, 14 Oct 1992 11:36
Non-intuitive behaviour of finger 1.36
Author: Goeran Uddeborg
Date: Wed, 14 Oct 1992 11:36
Date: Wed, 14 Oct 1992 11:36
59 lines
2263 bytes
2263 bytes
The finger program behaves a little non-intuitive when the --info flag
is given but no user is specified. The problem gets more obvious when
compiling with INFO_IS_DEFAULT defined.
The finger server gives no reply if asked for a long listing but no
user specified (given "/W " as input). It is thus not very useful to
call it that way. If finger is invoked as
finger --info
i.e. without any user specified, the info-flag is
explicitly disabled in finger.c. If it is invoked as
finger --info @host
it is not disabled, however. To me, it seems a brief listing ought to
be given in both these cases. A possible way to achieve this is
suggested in the patch below
*** /usr/local/src/gnu/finger-1.36/src/finger.c~ Thu Oct 1 20:02:07 1992
--- /usr/local/src/gnu/finger-1.36/src/finger.c Wed Oct 14 09:48:09 1992
***************
*** 170,180 ****
#endif
if (optind >= argc)
! {
! options &= FACE;
!
! call_finger ("", options, port);
! }
else
for (arg_index = optind; arg_index < argc; arg_index++)
call_finger (argv[arg_index], options, port);
--- 170,176 ----
#endif
if (optind >= argc)
! call_finger ("", options, port);
else
for (arg_index = optind; arg_index < argc; arg_index++)
call_finger (argv[arg_index], options, port);
***************
*** 266,272 ****
}
else
{
! if (info)
{
char *new_username = (char *)xmalloc (4 + strlen (username));
strcpy (new_username, "/W ");
--- 262,268 ----
}
else
{
! if (info && *username)
{
char *new_username = (char *)xmalloc (4 + strlen (username));
strcpy (new_username, "/W ");
Thread Navigation
This is a paginated view of messages in the thread with full content displayed inline.
Messages are displayed in chronological order, with the original post highlighted in green.
Use pagination controls to navigate through all messages in large threads.
Back to All Threads