🚀 go-pugleaf

In article <49b2cg$4e3@decaxp.harvard.edu> sarmad@scunix4.harvard.edu (Shaikh Sarmad) writes:

   Thank you Joev and Eugene for your suggestions. Both of the suggestions 
   work and I have solved my problem. Just wondering, which of the two 
   implementations would be more efficient (not that it's a problem!)


   *** Joev's suggestion ***
   : main (int argc, char **argv)
   : {
   : 	char cmd[100];
   : 	sprintf(cmd, "finger -m %s", argv[1]);
   : 	system(cmd);
   : }


   *** Eugene's suggestion ***
   : main (int argc, char **argv)
   : {	char cmd [80];
   :	strcpy (cmd, "finger -m ");
   :	strcat (cmd, argv[1]);
   :	system (cmd);
   : }

There is a problem with both of these though.

They do not check for overflow of the allocated space in `cmd'

What happens if argv[1]

a) does not exist?
b) is 156 chars long?

An execv() with dynamically allocated space would be the
better solution (I believe one was posted sometime).

tony