🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: mod.amiga
Article #18

vt100 emulator bug fix

#18
From: doc
Date: Sat, 19 Jul 1986 20:39
26 lines
1695 bytes
Thanks to Wayne Hamilton, there is a bug fix to put into the vt100 terminal
emulator posted by Dave Wecker in mod.amiga.sources.  The fix has been made
in the archived sources already.  In his letter to me, he says...

> From: uiucdcs!uxc.CSO.UIUC.EDU!hamilton@ecn (Wayne Hamilton)
> 
>     there's a typo in the vt100 emulator code from dave wecker.  in file
> window.c, at line 27:
> 	if (class=RAWKEY)
> should be:
> 	if (class == RAWKEY)

    To this, I will add just a bit on C style.  This error would have never
surface had he written it like this:
	if (RAWKEY == class)
    By switching the order of the comparison, forgetting the `=' would have
caused a compiler error since one cannot assign something to a #define'd
constant.  This is a very good way to catch these errors and has saved
me a number of times.
				    Craig Norborg (aka Doc Pierce)
				    mod.amiga.{sources|binaries} moderator
Uucp: { decvax, icalqa, ihnp4, inuxc,   sequent, uiucdcs}!pur-ee!pucc-j!doc
      { decwrl, hplabs, icase, psuvax1, siemens, ucbvax }!purdue!pucc-j!doc

USnail: 539 N. Grant Street
	W. Lafayette IN 47906
Technical Details
Message-ID: <550@ulowell.UUCP>
Path: arc1-ca.pugleaf.net!utzoo!decvax!wanginst!ulowell!doc@pucc-j

Show Full Headers
Complete Article Headers
Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10.2 9/5/84; site ulowell.UUCP
Path: arc1-ca.pugleaf.net!utzoo!decvax!wanginst!ulowell!doc@pucc-j
From: doc@pucc-j
Newsgroups: mod.amiga
Subject: vt100 emulator bug fix
Message-ID: <550@ulowell.UUCP>
Date: Sat, 19-Jul-86 16:39:53 EDT
Article-I.D.: ulowell.550
Posted: Sat Jul 19 16:39:53 1986
Date-Received: Sat, 19-Jul-86 22:07:40 EDT
Sender: page@ulowell.UUCP
Organization: University of Lowell
Lines: 26
Keywords: VT100, Terminal program, Big Fix
Approved: page@ulowell.UUCP