minor rdist bug

Thread View: net.bugs.4bsd

2 messages

[T] Back to Threads [V] Tree View [G] Group Articles

2 total messages Started by David L. Stevens Tue, 21 Oct 1986 14:26

#1705

Author: David L. Stevens
Date: Tue, 21 Oct 1986 14:26

34 lines
1510 bytes

Index:	/usr/src/ucb/rdist/server.c 4.3BSD

Description:
	rdist doesn't propagate sticky bits.
Repeat-By:
	touch /tmp/hose;chmod 1751 /tmp/hose;rdist -c /tmp/hose <machine>
Fix:
	The fix is simply to set the mask of bits which require a chmod()
	to include the sticky bit, as well as the setuid and setgid bits.
	Diffs follow.

*** OLD server.c Tue Oct 21 09:15:06 1986
--- server.c	 Tue Oct 21 09:10:29 1986
***************
*** 1035,1041
  	if (userid)
  		setreuid(userid, 0);
  	if (chown(file, uid, gid) < 0 ||
! 	    (mode & 06000) && chmod(file, mode) < 0) {
  		note("%s: chown or chmod failed: file %s:  %s",
  			     host, file, sys_errlist[errno]);
  	}

--- 1035,1041 -----
  	if (userid)
  		setreuid(userid, 0);
  	if (chown(file, uid, gid) < 0 ||
! 	    (mode & 07000) && chmod(file, mode) < 0) {
  		note("%s: chown or chmod failed: file %s:  %s",
  			     host, file, sys_errlist[errno]);
  	}
-- 
					+-DLS  (dls@j.cc.purdue.edu)

Re: minor rdist bug

#1721

Author: Jay Lepreau
Date: Thu, 30 Oct 1986 03:08

13 lines
1151 bytes

There is a minor security problem with the recommended fix to allow
rdist to propagate sticky bits: normally only root is allowed to set the
sticky bit. But with the proposed fix, if a user has a machine on which
he has root privileges, and then rdist's (as himself) a file to a
machine on which he does not have root privs, he can introduce binaries
with the sticky bit set.  No big deal, but here's a better way to fix
rdist/server.c:

1038c1038,1039
< 	    (mode & 06000) && chmod(file, mode) < 0) {
---
> 	    (mode & (06000 | (userid ? 0 : S_ISVTX))) &&
> 	    chmod(file, mode) < 0) {

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads