more on flushtty vs XON/XOFF

Thread View: net.bugs.v7

1 messages

[T] Back to Threads [V] Tree View [G] Group Articles

1 total messages Started by utzoohenry Thu, 31 Mar 1983 16:01

#117

Author: utzoohenry
Date: Thu, 31 Mar 1983 16:01

18 lines
1125 bytes

A little while ago, I observed that there was an apparent bug in the
V7 tty driver:  the flushtty() routine turns off the "stopped" bit
used for stop/start handshaking.  This is really fun if your terminal
does expect the cpu to honor this protocol all the time.  At the time,
I asked if anybody could think of any reason why this behavior was
useful (except at final close, when the bit gets taken care of by
other code anyway!).  No replies.  I think it is safe to call this
line of code an out-and-out mistake, and call for its removal.  The
offending line is about line 339 in tty.c, in the flushtty() routine,
and reads:

	tp->t_state &= ~TTSTOP;

The fix is, remove it.  I haven't actually had a chance to try this
yet;  I will post the results when I do.

					Henry Spencer
					U of Toronto

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads