Article View: net.bugs
Article #4Checknews (2.10.3 4.3bsd-beta 6/6/85) bug + fix
From: Sam Kendall
Date: Wed, 20 Nov 1985 03:01
Date: Wed, 20 Nov 1985 03:01
23 lines
1286 bytes
1286 bytes
Description:
Checknews dumps core on machines like our Codata 68000,
which don't like indirection of NULL. It will probably
write in low-addressed locations on other machines.
Fix:
In the code below, "username" can be NULL. The fix is
copied from funcs2.c.
396,398c397,399
< if (username[0] == 0)
< strcpy(username, p->pw_name);
< strcpy(userhome, p->pw_dir);
---
> if (username == NULL || username[0] == 0)
> username = AllocCpy(p->pw_name);
> userhome = AllocCpy(p->pw_dir);
----
Sam Kendall "This bug found with
Delft Consulting Corp. The Bcc Compiler, a
(212) 243-8700 'C' runtime checker."
{allegra, seismo!cmcl2, ihnp4}!delftcc!sam
Technical Details
Message-ID:
<103@delftcc.UUCP>Path:
arc1-ca.pugleaf.net!utzoo!watmath!clyde!cbosgd!ihnp4!houxm!whuxl!whuxlm!akgua!gatech!seismo!cmcl2!philabs!rdin!delftcc!samShow Full Headers
Complete Article Headers
Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP Posting-Version: version B 2.10.2 9/3/84; site delftcc.UUCP Path: arc1-ca.pugleaf.net!utzoo!watmath!clyde!cbosgd!ihnp4!houxm!whuxl!whuxlm!akgua!gatech!seismo!cmcl2!philabs!rdin!delftcc!sam From: sam@delftcc.UUCP (Sam Kendall) Newsgroups: net.bugs,net.news.b Subject: Checknews (2.10.3 4.3bsd-beta 6/6/85) bug + fix Message-ID: <103@delftcc.UUCP> Date: Tue, 19-Nov-85 22:01:04 EST Article-I.D.: delftcc.103 Posted: Tue Nov 19 22:01:04 1985 Date-Received: Sat, 23-Nov-85 03:54:38 EST Organization: Delft Consulting Corp., New York Lines: 23