🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

2 total messages Started by tom Thu, 04 Oct 1984 17:58
significant bug in readnews 2.10, fix included
#311
Author: tom
Date: Thu, 04 Oct 1984 17:58
21 lines
1590 bytes
[bug bait]

	Having just become the local net-news administrator, my first job
was to find why readnews was hanging when it tried to read net.micro. The
problem, it turns out, relates to the bitmap[] array and the clear macro.
	When the article number (stored in the global 'bit') was >= 8193, 
calling clear(bit) slopped over the end of the bitmap[] array, and fudged
the next int, which just happened to be the global 'bit'. 'bit' got reset to
8192 so that when it was incremented to look at the next article, it started
looking for 8193 again, and thus entered an infinite loop.
	The fix is to redefine the size of bitmap[] in rextern.c. I took it
from bitmap[1024] to bitmap[2048], and it seems to have solved the problem.
I haven't sat down to figure at what point this new sized array will be overrun.
	If I'm going over old ground, or missing something obvious , please
don't turn up the flames too high. As I said, I'm new at this job.

	The above applies to version 2.10 of readnews. We are running 4.2 BSD.

					regards,
						Tom Neuendorffer
					{mcnc,decvax,pitt} !idis!tom
Re: significant bug in readnews 2.10, fix included
#316
Author: Zonker T. Chuqui
Date: Mon, 08 Oct 1984 05:56
11 lines
954 bytes
The proper fix to this is to upgrade to 2.10.2, recently posted to
net.sources. There are a large number of fixes in the release including a
decent fix for the 8192 overflow.

chuq

-- 
From the Department of Bistromatics:            Chuq Von Rospach
{amd,decwrl,fortune,hplabs,ihnp4}!nsc!chuqui    nsc!chuqui@decwrl.ARPA

How about 'reason for living?'
Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads