Spaces on input

Thread View: net.games.hack

4 messages

[T] Back to Threads [V] Tree View [G] Group Articles

4 total messages Started by Kriton Kyrimis Mon, 22 Apr 1985 16:33

#473

Author: Kriton Kyrimis
Date: Mon, 22 Apr 1985 16:33

10 lines
1036 bytes


The input routine in hack 1.0.2 does not seem to recognise spaces. This is bad
enough when you have to call a scroll of enchant armor "enchant_armor" or
your dog "the_ferocious_man-eating_dog, but the real problem is with the use
of wands of wishing. Saying "+3crysknife" works, and "genocide" does give you a
scroll of genocide, but how do you ask for more complex things like plate mail
(or +7 plate mail - does this feature still exist in the new version?)

	Kriton Kyrimis	(princeton!tilt!kyrimis)

Re: Spaces on input

#501

Author: DARIN JOHNSON
Date: Wed, 24 Apr 1985 04:25

13 lines
1495 bytes

In article <275@tilt.FUN>, kyrimis@tilt.FUN (Kriton Kyrimis) writes:
> The input routine in hack 1.0.2 does not seem to recognise spaces. This is bad
> enough when you have to call a scroll of enchant armor "enchant_armor" or
> your dog "the_ferocious_man-eating_dog, but the real problem is with the use
> of wands of wishing. Saying "+3crysknife" works, and "genocide" does give you a
> scroll of genocide, but how do you ask for more complex things like plate mail
> (or +7 plate mail - does this feature still exist in the new version?)

Funny, I wish for +3 crysknife all the time and it works fine.  There is
an option "rest on space" that may inadvertantly cause this to work or
not, but I'm not sure.  I call my dog things with spaces in it and it
works also.  I would look at the source (If you have it) to see if there
is anything system dependent.

Re: Spaces on input

#499

Author: Andries Brouwer
Date: Wed, 24 Apr 1985 12:18

10 lines
898 bytes

In article <275@tilt.FUN> kyrimis@tilt.FUN (Kriton Kyrimis) writes:
>
>The input routine in hack 1.0.2 does not seem to recognise spaces.

It seems that a space is not everywhere regarded as a printing character.
Fix in hack.tty.c:
127c127
< 		} else if(isprint(c)) {
---
> 		} else if(isprint(c) || c == ' ') {

Re: Spaces on input

#504

Author: ampe
Date: Thu, 25 Apr 1985 09:30

19 lines
1200 bytes

In article <275@tilt.FUN> kyrimis@tilt.FUN (Kriton Kyrimis) writes:

>The input routine in hack 1.0.2 does not seem to recognise spaces. ...
...
>	Kriton Kyrimis	(princeton!tilt!kyrimis)

The bug lies in the getlin() routine in hack.tty.c.  This file includes
ctype.h, which defines isprint().  On some machines, isprint() answers
false to spaces, thus the error.  A fix is to change line 127 of
hack.tty.c from:

		} else if(isprint(c)) {
to:
		} else if(isprint(c) || c == ' ') {

			--John Ampe
			    UCLA

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads