🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

Article View: net.notes
Article #169

bug in archiver - (nf)

#169
From: root
Date: Sat, 21 Jan 1984 08:49
43 lines
2259 bytes
#N:uo-vax1:11900002:004:1613
uo-vax1!root    Jan 13 14:37:00 1984

This seems to be the place to report notes bugs, if someone thinks
it should go elsewhere let me know and I'll repost it to the appropriate
group.  This may have been reported sometime in the past, but it hasn't 
in the last 6-8 months, so here it is.


There appears to be a bug in archiver.c.  If you say `nfarchive -nn`
where nn >= OLDGROUP all your notesfiles get deleted!!  The problem
is that the check for group expiration doesn't look at OLDGROUP, but
rather (OLDGROUP - daysold) where daysold would equal nn in the above
incantation.

The fix is simple:

change line 137 archiver.c from
    if (current - buf.st_mtime > 60*60*24*(OLDGROUP-daysold)) {
to
    if (current - buf.st_mtime > 60*60*24*OLDGROUP) {

The default for daysold is ARCHTIME which is 14, the default for OLDGROUP
is 30, so OLDGROUP-daysold = 16 by default.  This means that notesfiles
are empty before being removed.  If you give the command mentioned above
the program will leave nn days worth of notes, but then trash your 
notesfile.  

We recently purchased a new disk which allowed us to keep notesfiles longer.
You could say that I was quite surprised when, after changing the archiving
time to 30 days, people starting asking me what happened to the notesfiles!


Also, we often times wonder if our notes ever make it very far as when we
have ever requested anything the only people that have acknowledged our 
requests were local.  If people out in the distance receives this (Cal, Ill,
NJ, etc) would you please send mail acknowledging it.

Thanks,

Mark Aitken
University of Oregon
{hp-pcd,hp-cvd,tektronix}!uoregon!marka
Technical Details
Message-ID: <4351@hp-pcd.UUCP>
Path: arc1-ca.pugleaf.net!utzoo!linus!philabs!seismo!hao!hplabs!hp-pcd!uoregon!uo-vax1!root

Show Full Headers
Complete Article Headers
Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10.1 6/24/83; site hp-pcd.UUCP
Path: arc1-ca.pugleaf.net!utzoo!linus!philabs!seismo!hao!hplabs!hp-pcd!uoregon!uo-vax1!root
From: root@uo-vax1.UUCP
Newsgroups: net.notes
Subject: bug in archiver - (nf)
Message-ID: <4351@hp-pcd.UUCP>
Date: Sat, 21-Jan-84 03:49:34 EST
Article-I.D.: hp-pcd.4351
Posted: Sat Jan 21 03:49:34 1984
Date-Received: Sun, 22-Jan-84 08:17:22 EST
Sender: notes_gateway@hp-pcd.UUCP
Organization: University of Oregon, Eugene, OR
Lines: 46