🚀 go-pugleaf

"Alfred" <alf@no.spam.not.valid.email> wrote in message
news:4366ccd3$1@newsgroups.borland.com...

> I have tryed a ProcessPacket routine like :

That code is wrong for three reasons:

>        char *a = new char[DataLength];

1) You are allocating an extra buffer that is not actually being used for
anything.

>        a = (char*)Data;

2) you are then reassigning the pointer to point to the Data parameter
instead of the buffer you allocated.  You have now lost your pointer to the
buffer.  You can never free it, thus leaking the allocated memory.

>        delete[] a;

3) Since you are now pointing to the Data parameter, you are freeing memory
that is owned by the TMemoryStream.

The routine should be like this instead:

    void__fastcall TForm1::ProcessPacket(TCustomWinSocket *Socket, void
*Data, int DataLength)
    {
        // process Data as needed...
        Memo->Lines->Add(AnsiString((char*)Data, DataLength));
    }

> Sender program send an example with :

That code is wrong as well, for the same reasons as above.  Not only that,
but you are not checking the return value of SendBuf(), either.  You need to
do so, ie:

    bool __fastcall TForm1::SendData(TCustomWinSocket *Socket, void *Data,
int DataSize)
    {
        LPBYTE pBuf = (LPBYTE) Data;

        while( DataSize > 0 )
        {
            int Sent = Socket->SendBuf(pBuf, DataSize);
            if( Sent < 1 )
            {
                if( Sent == 0 )
                    return false; // disconnected

                if( WSAGetLastError() != WSAEWOULDBLOCK )
                    return false; // error

                Sleep(50); // keep waiting
            }
            else
            {
                pBuf += Sent;
                DataSize -= Sent;
            }
        }

        return true;
    }


    char *buf = "1234567890";
    int len = 10;

    if( SendData(Socket, &len, sizeof(int)) )
        SendData(Socket, buf, len);


Gambit