🚀 go-pugleaf

"Remy Lebeau (TeamB)" <no.spam@no.spam.com> wrote in message 
news:42727b69$1@newsgroups.borland.com...

[snip]

> You should be checking for WSA_IO_PENDING, not ERROR_IO_PENDING.

[snip]

> Also, just for the record, your use of exception handling is 
> horrible in
> these code snippets of yours.  You are leaking a lot of resources 
> when you
> decide to throw your exceptions because you are not closing/freeing
> resources you allocated beforehand.

I restructured the server so that when a exception does get thrown, no 
memory is leaked. And I changed the CreateListenSocket code to this:

int nRet;
int nZero = 0;
struct sockaddr_in addrlocal = {0};

g_sdListen = WSASocket(AF_INET, SOCK_STREAM, IPPROTO_TCP, NULL, 0, 
WSA_FLAG_OVERLAPPED);
if( g_sdListen == INVALID_SOCKET )
 throw Exception(myprintf("WSASocket(g_sdListen) failed: %d\n", 
WSAGetLastError()));

addrlocal.sin_family = AF_INET;
addrlocal.sin_port = 52877;
addrlocal.sin_addr.s_addr = INADDR_ANY;

nRet = bind(g_sdListen, (sockaddr*) &addrlocal, sizeof(addrlocal));
if( nRet == SOCKET_ERROR )
 throw Exception(myprintf("bind() failed: %d\n", WSAGetLastError()));

nRet = listen(g_sdListen, 50);
if( nRet == SOCKET_ERROR )
 throw Exception(myprintf("listen() failed: %d\n", 
WSAGetLastError()));

nZero = 0;
nRet = setsockopt(g_sdListen, SOL_SOCKET, SO_SNDBUF, (char *)&nZero, 
sizeof(nZero));
if( nRet == SOCKET_ERROR )
 throw Exception(myprintf("setsockopt(SNDBUF) failed: %d\n", 
WSAGetLastError()));

But now the server does not even work 50% of the time.

Jonathan