🚀 go-pugleaf

"Victor G. Baron" <vgbaron@hotmail.com> wrote in message
news:18afov85hscnd8n1qjjh41bqgceis3cb0i@4ax.com...

> The bulk of this code was copied from the Using Threads example
> in the Helpfile for TServiceApplication. I can't answer for why they
> set it up that way.

Because Borland's examples are hardly ever very accurate.  Sometimes they
don't realize they are writing examples on top of their own bugs.

> The delete is outside the while loop.

It was hard to tell in your previous message, you put your "thank you" in
the middle of your code, but it definately did look like you are calling
'delete' inside the loop before calling Sleep().  Can you verify that it
really is *outside* the loop?  What does the code look like without the
"thank you" getting in the way?

> I've moved stuff around trying different things but this is back
> to the original way.
>
> I've stripped out everything except the code that crashes.

From what you have described earlier, and what I have suggested, the thread
code should look something like this:

    class TConvThread : public TThread
    {
    protected:
        void __fastcall AfterConstruction();
        void __fastcall Execute();
    public:
        __fastcall TConvThread();
        __fastcall ~TConvThread();

        TStringList* inputfile;
        String input_file;
        String output_file;
    };

    __fastcall TConvThread::TConvThread()
        : TThread(true)
    {
        inputfile = new TStringList;
        inputfile->Sorted = true;

        input_file ="C:\\auth_user_file.txt";
        output_file =
"H:\\Borland\\CBuilder5\\Projects\\VPC_CONV\\onlineusers.txt";
    }

    __fastcall TConvThread::~TConvThread()
    {
        delete inputfile;
    }

    void __fastcall TConvThread::AfterConstruction()
    {
        Resume();
    }

    void __fastcall TConvThread::Execute()
    {
        while( !Terminated )
        {
            //...
            inputfile->LoadFromFile(input_file);
            //..
            Beep();

            // loop the sleeping so that the thread is not blocked
            // sleeping for 10 minutes in case the application needs
            // to stop the thread, such as during program shutdown,
            // so that the thread can stop sleeping and terminate in a
            // timely fashion..  The alternative is to use CreateEvent()
            // and WaitForSingleObject() instead of Sleep() and have
            // the application signal the event to "wake up" the thread.

            for(int x = 0; (x < 600) && (!Terminated); ++x)
                Sleep(1000);
        }
    }


Gambit