🚀 go-pugleaf

"Feico" <feicorem0veth1s@gmx.net> wrote in message
news:a7k0d0lm7htcsem1ve3179ld2bcpsj8hbs@4ax.com...

>         inaddr.s_addr = ::inet_addr(domain);
>         if (inaddr.s_addr == INADDR_NONE)
>         {
>           host = ::gethostbyname(domain);
>         }
>         else
>         {
>           host = ::gethostbyaddr((const char *)&inaddr, sizeof(inaddr),
AF_INET);
>         }

You don't need gethostbyaddr().  You already have the IP address converted
to a u_long via inet_addr(), so there is no need to convert it a second
time.

>         sockaddr_in sa;

You need to zero out the sin_zero member.  You are not doing that.  In fact,
you should always zero out Win32 API structures before then filling them in
with the desired values.  The easiest way to do that is with the following
shorthand:

    sockaddr_in sa = {0};

>         sa.sin_port = (unsigned short) /*sp->s_*/port;

Why not have your function accept an unsigned short to begin with?  Then you
don't need the cast.

>         if (::connect(socket, (sockaddr *)&sa, sizeof(sa)) < 0)
>         {
>            ReportError("connection to host failed");   //THIS is executed
>         }

What is the actual return value of WSAGetLastError()?

I suggest you use the following code instead:

    SOCKET Opensocket(char *domain, unsigned short port)
    {
        unsigned long addr = ::inet_addr(domain);
        if( addr == INADDR_NONE )
        {
            hostent *host = ::gethostbyname(domain);
            if( host != NULL )
                addr = *(unsigned long*)(host->h_addr);
            else
                ReportError("error");
        }

        SOCKET socket = ::socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
        if( socket == INVALID_SOCKET )
            ReportError ("socket invalid");

        sockaddr_in sa = {0};
        sa.sin_family = AF_INET;
        sa.sin_port = port;
        sa.sin_addr.s_addr = addr;

        if( ::connect(socket, (sockaddr *)&sa, sizeof(sa)) == SOCKET_ERROR )
            ReportError("connection to host failed");

        return socket;
    }

    void __fastcall TForm1::Button2Click(TObject *Sender)
    {
        WSADATA WSAData = {0};
        if( WSAStartup(MAKEWORD(2, 0), &WSAData) == 0 )
        {
            SOCKET socket = Opensocket("mail.home.nl", 110);
            if( socket != INVALID_SOCKET )
            {
                // use socket as needed...
                ::shutdown(socket, SD_SEND);
                ::closesocket(socket);
            }
            WSACleanup();
        }
    }


Gambit