🚀 go-pugleaf

John Steel wrote:
>     public Collection getValues() {
>         return gameListTreeMap.values();
>     }
> ...
> }
> 
> As you can see getValues() returns a Collection, so I can't see what the 
> warning is trying to tell me.

gameListTreeMap is a TreeMap<String, GameRec>, so the values method 
returns Collection<GameRec>.  Since your getValues method returns a 
plain Collection without any generic type parameters, you've lost the 
restriction to GameRec, which is an unchecked conversion from 
Collection<GameRec> to Collection.  There are a few ways you can get rid 
of the problem.

1. Change your getValues method's return type to Collection<GameRec>. 
This is probably the most type safe solution, but depending on how big 
your API is, it might just propagate the problem up the tree.  Now 
anyone that calls your getValues method expecting a Collection is going 
to get a similar warning.  In other words:

     Collection foo = gameListManager.getValues(); // warning!

2. Add a SuppressWarnings annotation to the getValues method.  This 
basically tells the compiler, "Shut up, I know what I'm doing."  It 
works, and you probably do know what you're doing, but my preference is 
to only do that when I have no other choice (ex. the warning comes from 
interacting with some 3rd party API that I can't change).

     @SuppressWarnings("unchecked")
     public Collection getValues() {
         return gameListTreeMap.values();
     }

-- 
Gillmer J. Derge [TeamB]