🚀 go-pugleaf

"Gillmer J. Derge [TeamB]" <spam@gillmerderge.com> wrote in message 
news:4684fd6d@newsgroups.borland.com...

>> As you can see getValues() returns a Collection, so I can't see what the 
>> warning is trying to tell me.
>
> Collection<GameRec> to Collection.  There are a few ways you can get rid 
> of the problem.
>
> 1. Change your getValues method's return type to Collection<GameRec>. This 
> is probably the most type safe solution, but depending on how big your API 
> is, it might just propagate the problem up the tree.  Now anyone that 
> calls your getValues method expecting a Collection is going to get a 
> similar warning.  In other words:
>
>     Collection foo = gameListManager.getValues(); // warning!

Thanks very much for your help, this is very kind of you.
I am in control of all the source, and the api is pretty much limited to 
these 2 classes (at present!).
As expected, when I changed the GameListManagers getValues() to read

    public Collection<GameRec> getValues() {
        return gameListTreeMap.values();
    }

I found it compiled fine but then the original calling line now gives these 
2 errors:
"GameListRenderer.java": cannot find symbol; symbol  : constructor 
ArrayList(java.util.Collection<GameRec>), location: class 
java.util.ArrayList<java.util.Collection> at line 94, column 40
"GameListRenderer.java": internal error; cannot instantiate 
java.util.ArrayList.<init> at java.util.ArrayList<java.util.Collection> to 
() at line 94, column 40

I'm trying to think this through by describing it in English - I think I'm 
asking for an ArrayList of GameRecs, but we know games.getValues() now 
returns the type safe Collection so its almost as if the syntax end up like 
ArrayList<Collection<GameRec>> gameList =...  , but that wouldn't compile at 
all

(the original caller is     ArrayList<Collection> gameList = new ArrayList 
<Collection> (games.getValues()); ).

I too would like a clean build without "hacks".  There are a few others of 
this ilk relating to Comparators, so I'd like to fix those having understood 
this one.