🚀 go-pugleaf

Konrad Schwarz (schwarz@a3.complang.tuwien.ac.at) wrote:
: In article <4ggbns$86s@solutions.solon.com>, Lawrence Kirby writes:
: |> This could be better written as:
: |> 
: |>      static const char upmap[26] = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
: 
: or even better as
: 
:       static const char upmap [] = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";

As long as you don't mind the trailing '\0' being appended to upmap,
that is.

: The original posting also had code of the form
: 	"ABC...XYZ" [ expr % 26 ]
: 
: by introducing upmap, we can now write
: 
: 	upmap [ expr % (sizeof upmap / sizeof *upmap) ]
: 
: which is good for two reasons:
: 	if we later change the length of the string, nothing breaks
: 	if we later change the type of upmap, nothing breaks

However, it is bad for one reason:  If upmap is declared as upmap[]
(without specifying the size as 26), then sizeof upmap == 27.

--
Mark C. Orton
employed by (but not speaking for)
Pulse Communications, Inc.