🚀 go-pugleaf

blueman wrote:

>> Perhaps it does.  But I already added a fix a day or two ago, tested
>> it and committed to the repository on launchpad.  Unfortunately, this
>> to-and-fro hasn't contributed all that much to the problem, after the
>> initial discussion.  There are some 20 odd messages in this thread.  I
>> don't think this mode of communication has been very effective.
> 
> Personally, I find that comment unfair. I have:
>        - Identified multiple show-stopper bugs in the routine
>        - Coded bug fixes
>        - Suggested and discussed extensions to make it usable on
>          multiple messages rather than running them together
>        - Coded the extension
> 
> I have shared my code the whole way through and have accepted input from
> you and Julian which ultimately made it better.

Agreed that you have done all of these.  But, after we have decided on 
a reasonable course of action (your proposal on 5 Jan, 23:50 UTC), 
things didn't go well.  You have posted the fixes here.  It wasn't a 
patch file.  So, I had to insert it manually into the code  base and 
test it.  When I tested it, it didn't work.  So I debugged it, found 
the fixes, committed them to the code base, and also posted a patch 
file for you (based on the code that you posted).  So, it is easy 
enough for you to test my version.  Did you test it?  Did you go back 
and retest your code posted here (on 6th Jan, 16:42 UTC)?

Your response was

    "Please try with the two patches I submitted. They really just
     correct probably typos. I don't think the changes you made are
     necessary. But please try my changes first..."

This is not helpful.  I have tried the "two patches you submitted", 
found problems, and sent you back the corrections.  Did you apply them 
and test them?  If you didn't do so, the further exchange didn't make 
any contribution.  In fact, it wasn't clear if we were even talking 
about the same things any more.

(My apologies for having misremembered that I committed the changes to 
launchpad.  I posted the patches here and was waiting to hear from 
you.  I have now uploaded my version to launchpad so that you can test 
it properly.)

I cannot be spending as much time on each and every issue.  If you 
want to make a contribution, please state your bug clearly and provide 
a *patchfile*, which I can apply and test, and after I accept it, we 
can move on.  I am also at liberty to revise your patches so as to 
maintain the consistency and coherence of the code base.  If you send 
me patches that fail my testing, that will make it harder for me to 
accept patches from you in future!  So, take the time to test them 
properly.  I am not going anywhere.

Cheers,
Uday