🚀 go-pugleaf

Jamie Zawinski writes:
 > I have added some hooks to VM; patch below.
 > [...]
 > The hooks I have added are:
 > 
 >  vm-summary-mode-hooks	Should be no argument with this one :-)

okey.

 >  vm-preview-message-hook	Called when a message is first displayed if
 > 				you have previewing enabled.

What would hook functions expect the operating environment to be?
Current buffer, clipping region, etc.  This question applies to
all of these hooks.

 >  vm-show-message-hook		Called when a message is first fully 
 > 				displayed, which is only different from when
 > 				it is selected if you're using previewing.

okey.

 >  vm-show-new-message-hook	Called just after vm-show-message-hook when
 > 				the message being selected is new (has just
 > 				been incorperated into the folder.)

Why _after_ vm-show-message-hook?  My first impression would have
been that this hook would be called first, and _perhaps_
vm-show-message-hook wouldn't be called if this hook were non-nil.

 >  vm-show-unread-message-hook	Called just after vm-show-message-hook when
 > 				the message being selected is marked as
 > 				unread.

Same questions as for vm-show-new-message-hook.

 > I have named them -hook instead of -hooks because that's the pattern that
 > almost all of the emacs hooks follow, but I would have no real argument if
 > they were called -hooks to be more consistent with the rest of the VM hooks.

I will probably resolve the -hook vs. -hooks naming issue by
making VM run hooks under both names.

 > I'm not sure that the distinction between "new" messages and "unread"
 > messages is a useful one, so perhaps those two should be combined into
 > one hook.

I don't find it particularly useful either, but I was modeling VM
after Berkeley Mail in the beginning, so I made the distinction.

 > Kyle, will you please put these patches into your next release of VM?
 > 
 > If the answer is "no" or "maybe" or "I'll think about it", then please
 > send me mail so I can browbeat you in to it.

I'll think about it.  I want the semantics to be more fully
worked out, though.