🚀 go-pugleaf

Hi folks,
using codecenter i got some notes that may interest
you:

Using:  regex.c, test/iregex.c, test/upcase.c

general problems:

  regex.c:   line 4814:  2nd param "preg" not used
		solution: use /*ARGSUSED*/

  iregex.c:  line 38:  char pat[500] = "";  not allowed
		solution:  char pat[500];
			   ...
			   pat[0] = '\0';

	     line 52:  strlen() not defined
		solution:  #include <string.h>

	     line 37:  char c;  not used


run-time problems:

  PATTERN:  ab*
  STRING:   qqq

  regex.c:   line 2030 STORE_NUMBER(loc+1,arg);
			"losing info due to sign extension"
			arg: -9
		solution: i'm not sure, but there might
			  a cast to (unsigned) senseful

  iregex.c (or regex.c ?):
	     line 65, 69: calls print_regs() but
			  regs.num_regs is NOT set.
		solution: test return value of re_match()
			  and re_search()

		OR is it a bug ??
		Should re_match() and re_search() set
		regs.num_regs to 0 ???
		(please document it !!!)


This infos may be lowest priority but anyway i thought
they could help.
Would be glad to get a reply.

--------
Nico
                                 address: BREDEX GmbH
email:   nico@bredex.de                   Nicolai Josuttis
                                          Kastanienallee 2a 
phone:   +49 531 75480                    D-3300 Braunschweig
fax:     +49 531 796358                   Germany
--------