🚀 go-pugleaf

RetroBBS NetNews Server

Inspired by RockSolid Light RIP Retro Guy

1 total messages Started by Dirk Grunwald Mon, 12 Dec 1988 19:11
make-3.26 bug
#1427
Author: Dirk Grunwald
Date: Mon, 12 Dec 1988 19:11
38 lines
1595 bytes
This is for gnumake-3.26. I previously posted the wrong patch.

re: patch to get parallel make to work

The problem is the following:
         
        + in decode_switches, you call decode_env_switches. So far so good.
        + after decode_switched, you call  new_environ () 
 
          this builds MAKEFLAGS and MFLAGS from the command line switches.

          however, if the parameter is a positive_int && == 'j' (i.e. -j) 
          then MFLAGS is set to -j 1

This has the advantage that it doesn't pass the parallel-ism to the child,
however....

	+ decode_env_switches is called again

Now that MFLAGS has ``-j 1'' in it, job_slots of over-written, being set
back to 1.

The fix I did is to just remove this check & to pass the -j value for the
current value of job_slots. However, to keep the previous meaning,
perhaps the check should first insure that job_slots has the default value
before resetting it to the default value?

I'm not certain what the intent was. Roland?

Dirk Grunwald
Univ. of Illinois
grunwald@m.cs.uiuc.edu

--
Dirk Grunwald
Univ. of Illinois
grunwald@m.cs.uiuc.edu
Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads