Bug in GNU make 3.55

Thread View: gnu.utils.bug

1 messages

[T] Back to Threads [V] Tree View [G] Group Articles

1 total messages Started by Karl Fox Thu, 07 Sep 1989 17:41

#408

Author: Karl Fox
Date: Thu, 07 Sep 1989 17:41

28 lines
1393 bytes

GNU Make version 3.55 (gotten from osu-cis) doesn't expand $(@D)
correctly -- it trims off the last character of the directory name. 
This fixes it:

*** commands.c.ORIG	Thu Sep  7 11:47:18 1989
--- commands.c	Thu Sep  7 12:56:51 1989
***************
*** 134,140 ****
  #define	LASTSLASH(s)	rindex ((s), '/')
  #define	FILEONLY(s)	(p != 0 ? p + 1 : (s))
  #define	DIRONLY(s)	(p == 0 ? "./" : p == (s) ? "/" \
! 			 : savestring ((s), p - (s) - 1))
  
    /* $* is the stem from an implicit or static pattern rule.  */
    if (file->stem == 0)
--- 134,140 ----
  #define	LASTSLASH(s)	rindex ((s), '/')
  #define	FILEONLY(s)	(p != 0 ? p + 1 : (s))
  #define	DIRONLY(s)	(p == 0 ? "./" : p == (s) ? "/" \
! 			 : savestring ((s), p - (s)))
  
    /* $* is the stem from an implicit or static pattern rule.  */
    if (file->stem == 0)

Version 3.54 had the same problem.  Version 3.48 had a "+ 1", which
kept the trailing slash.
-- 
Karl Fox, Morning Star Technologies               karl@MorningStar.COM

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads