GNU finger 1.35 bug in lookup_tty in lib/tty.c

Thread View: gnu.utils.bug

1 messages

[T] Back to Threads [V] Tree View [G] Group Articles

1 total messages Started by Minh Tran-Le Mon, 07 Sep 1992 21:17

#756

Author: Minh Tran-Le
Date: Mon, 07 Sep 1992 21:17

28 lines
1215 bytes

The code for the function lookup_tty.c in lib/tty.c return a pointer
to stack allocated buffer.  That buffer should declared static.

Here is the change need to the file lib/tty.c.

Minh Tran-Le.
---------------------------------------------------------------------------
*** tty.c-	Thu Aug 20 09:55:04 1992
--- tty.c	Mon Sep  7 14:09:36 1992
***************
*** 86,90 ****
    char *fingerdir, *ttylocfile, *path_concat ();
    FILE *stream;
!   char buffer[256];
  
    stream = fopen (TTYLOCFILE, "r");
--- 91,95 ----
    char *fingerdir, *ttylocfile, *path_concat ();
    FILE *stream;
!   static char buffer[256];
  
    stream = fopen (TTYLOCFILE, "r");

-- 
Minh Tran Le.

ARPANET: tranle@intellicorp.arpa
UUCP:    ...sun!icmv!mtranle

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads