Article View: net.bugs.4bsd
Article #1730talk(1) displays incorrect error messages
From: Jeff Forys
Date: Sat, 08 Nov 1986 08:12
Date: Sat, 08 Nov 1986 08:12
46 lines
2319 bytes
2319 bytes
Index: /usr/src/ucb/talk/invite.c 4.3BSD FIX
Description:
talk(1) returns wrong error message under various circumstances.
Repeat by:
% talk foo # where `foo' is someone not logged in
[No connection yet]
>>> [Target machine does not recognize us] <<<
%
Fix:
The error messages do not jibe with their respective #define's
in "/usr/include/protocols/talkd.h". The solution is to reorder
the error messages properly as the following diff illustrates...
*** invite.c_old Sat Nov 8 00:46:33 1986
--- invite.c Sat Nov 8 00:46:32 1986
***************
*** 92,102 ****
}
static char *answers[] = {
"Your party is not logged on", /* NOT_HERE */
- "Target machine does not recognize us", /* MACHINE_UNKNOWN */
- "Target machine can not handle remote talk", /* UNKNOWN_REQUEST */
"Target machine is too confused to talk to us", /* FAILED */
"Your party is refusing messages", /* PERMISSION_REFUSED */
"Target machine indicates protocol mismatch", /* BADVERSION */
"Target machine indicates protocol botch (addr)",/* BADADDR */
"Target machine indicates protocol botch (ctl_addr)",/* BADCTLADDR */
--- 92,103 ----
}
static char *answers[] = {
+ "", /* SUCCESS */
"Your party is not logged on", /* NOT_HERE */
"Target machine is too confused to talk to us", /* FAILED */
+ "Target machine does not recognize us", /* MACHINE_UNKNOWN */
"Your party is refusing messages", /* PERMISSION_REFUSED */
+ "Target machine can not handle remote talk", /* UNKNOWN_REQUEST */
"Target machine indicates protocol mismatch", /* BADVERSION */
"Target machine indicates protocol botch (addr)",/* BADADDR */
"Target machine indicates protocol botch (ctl_addr)",/* BADCTLADDR */
Technical Details
Message-ID:
<1390@sunybcs.UUCP>Path:
arc1-ca.pugleaf.net!utzoo!mnetor!seismo!lll-crg!rutgers!clyde!watmath!sunybcs!forysShow Full Headers
Complete Article Headers
Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP Path: arc1-ca.pugleaf.net!utzoo!mnetor!seismo!lll-crg!rutgers!clyde!watmath!sunybcs!forys From: forys@sunybcs.UUCP (Jeff Forys) Newsgroups: net.bugs.4bsd Subject: talk(1) displays incorrect error messages Message-ID: <1390@sunybcs.UUCP> Date: Sat, 8-Nov-86 03:12:12 EST Article-I.D.: sunybcs.1390 Posted: Sat Nov 8 03:12:12 1986 Date-Received: Sun, 9-Nov-86 04:09:23 EST Reply-To: forys@sunybcs.UUCP (Jeff Forys) Organization: SUNY/Buffalo Computer Science Lines: 46 Keywords: bug