talk(1) displays incorrect error messages

Thread View: net.bugs.4bsd

1 messages

[T] Back to Threads [V] Tree View [G] Group Articles

1 total messages Started by Jeff Forys Sat, 08 Nov 1986 08:12

#1730

Author: Jeff Forys
Date: Sat, 08 Nov 1986 08:12

46 lines
2319 bytes

Index:	/usr/src/ucb/talk/invite.c 4.3BSD FIX

Description:

	talk(1) returns wrong error message under various circumstances.

Repeat by:

	% talk foo		# where `foo' is someone not logged in
	  [No connection yet]
     >>>  [Target machine does not recognize us]  <<<
	% 

Fix:
	The error messages do not jibe with their respective #define's
	in "/usr/include/protocols/talkd.h".  The solution is to reorder
	the error messages properly as the following diff illustrates...

*** invite.c_old	Sat Nov  8 00:46:33 1986
--- invite.c	Sat Nov  8 00:46:32 1986
***************
*** 92,102 ****
  }
  
  static	char *answers[] = {
  	"Your party is not logged on",			/* NOT_HERE */
- 	"Target machine does not recognize us",		/* MACHINE_UNKNOWN */
- 	"Target machine can not handle remote talk",	/* UNKNOWN_REQUEST */
  	"Target machine is too confused to talk to us",	/* FAILED */
  	"Your party is refusing messages",		/* PERMISSION_REFUSED */
  	"Target machine indicates protocol mismatch",	/* BADVERSION */
  	"Target machine indicates protocol botch (addr)",/* BADADDR */
  	"Target machine indicates protocol botch (ctl_addr)",/* BADCTLADDR */
--- 92,103 ----
  }
  
  static	char *answers[] = {
+ 	"",						/* SUCCESS */
  	"Your party is not logged on",			/* NOT_HERE */
  	"Target machine is too confused to talk to us",	/* FAILED */
+ 	"Target machine does not recognize us",		/* MACHINE_UNKNOWN */
  	"Your party is refusing messages",		/* PERMISSION_REFUSED */
+ 	"Target machine can not handle remote talk",	/* UNKNOWN_REQUEST */
  	"Target machine indicates protocol mismatch",	/* BADVERSION */
  	"Target machine indicates protocol botch (addr)",/* BADADDR */
  	"Target machine indicates protocol botch (ctl_addr)",/* BADCTLADDR */

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads